Fix: Fix updating JS versions with single quotes #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating a version in a version.js file support single and double quotes.
bjoernricks
force-pushed
the
fix-update-javascript-version
branch
from
302a831
to
31e1242
Compare
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 89.70% 89.67% -0.04%
==========================================
Files 82 82
Lines 5403 5406 +3
Branches 761 762 +1
==========================================
+ Hits 4847 4848 +1
- Misses 389 390 +1
- Partials 167 168 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
y0urself
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix updating JS versions with single quotes
Why
When updating a version in a version.js file support single and double quotes. GSA uses single quotes and updating the version during a release failed.