Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Find Copyright headers with old company #927

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Nov 14, 2023

What

Fixing the copyright header script

Why

There were issues, when copyright header had old company name (Greenbone Networks GmbH)
There were also issues removing "outdated lines"

References

DEVOPS-833

Checklist

  • Tests

Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@y0urself y0urself force-pushed the y0urself/cleanup branch 2 times, most recently from 80aca03 to 20c0e11 Compare November 14, 2023 13:24
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (34b451c) 90.58% compared to head (ba53096) 90.65%.

Files Patch % Lines
pontos/updateheader/updateheader.py 88.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
+ Coverage   90.58%   90.65%   +0.07%     
==========================================
  Files          97       97              
  Lines        6819     6828       +9     
  Branches      974      976       +2     
==========================================
+ Hits         6177     6190      +13     
+ Misses        442      438       -4     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0urself y0urself force-pushed the y0urself/cleanup branch 4 times, most recently from 03a873e to 2d8a80d Compare November 15, 2023 11:13
@y0urself y0urself marked this pull request as ready for review December 21, 2023 10:29
@y0urself y0urself requested a review from a team as a code owner December 21, 2023 10:29
@y0urself y0urself enabled auto-merge (squash) December 21, 2023 10:30
@y0urself y0urself merged commit 5634916 into main Dec 21, 2023
20 of 21 checks passed
@y0urself y0urself deleted the y0urself/cleanup branch December 21, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants