Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional NVD API Improvements #937

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Additional NVD API Improvements #937

merged 4 commits into from
Dec 1, 2023

Conversation

bjoernricks
Copy link
Contributor

What

  • Add additional test coverage
  • Improve CLI error output for http errors
  • Allow to request a number of results via CLI
  • Allow to use pagination via API and CLI

Why

Finalize NVD API

Checklist

  • Tests

Test additional code paths that were not covered yet.
…d CPE CLI

Extend pontos-nvd-cves, pontos-nvd-cve-changes and pontos-nvd-cpes CLIs
to allow requesting only a specific number of CVEs/CPEs.
Print more information from the error response.
Add a start_index argument for querying results on NVD APIs (CVEs, CVE
changes and CPEs). This will allow to use pagination via user requests.
@bjoernricks bjoernricks requested a review from a team as a code owner December 1, 2023 08:39
@bjoernricks bjoernricks added the make release To trigger GitHub release action. label Dec 1, 2023
@greenbonebot greenbonebot enabled auto-merge (rebase) December 1, 2023 08:40
Copy link

github-actions bot commented Dec 1, 2023

Conventional Commits Report

Type Number
Added 3
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7913e97) 90.51% compared to head (79de35d) 90.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   90.51%   90.57%   +0.05%     
==========================================
  Files          97       97              
  Lines        6814     6811       -3     
  Branches      973      973              
==========================================
+ Hits         6168     6169       +1     
+ Misses        445      442       -3     
+ Partials      201      200       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenbonebot greenbonebot merged commit a5e5ab0 into main Dec 1, 2023
21 checks passed
@greenbonebot greenbonebot deleted the nvd-api branch December 1, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants