Improve handling of get_aggregates #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_aggregates` command in GMP requires a `type` attribute defining the type of resource to gather data from. This commit implements this on `python-gvm` side and validates the type against a list retrieved from the `type_filter_columns ()` function in `gvmd/src/manage_sql.c`.
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 96.18% 96.31% +0.13%
==========================================
Files 10 10
Lines 2412 2418 +6
==========================================
+ Hits 2320 2329 +9
+ Misses 92 89 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the handling of the
get_aggregatesGMP command consistent with thehandling of other GMP commands.
This includes verifying that parameters required in GMP are present and contain
a valid value.
The
get_aggregatesGMP command allows many optionalparameters.
The optional parameters can be passed as
kwargskey-value pairs, but arecurrently not validated.
Checklist: