Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize gmp8 part 2 #133

Merged
merged 9 commits into from
Jun 19, 2019
Merged

Finalize gmp8 part 2 #133

merged 9 commits into from
Jun 19, 2019

Conversation

bjoernricks
Copy link
Member

@bjoernricks bjoernricks commented Jun 18, 2019 •
edited

Checklist:

@bjoernricks
Move docs section to the top of the README
acf121b 
Put the link to the documentation more prominent to the top of the
README. Extend the section by mentioning the README only gives a short
overview.
@bjoernricks
Update comment in code example for gmp script at README
67b830f
@bjoernricks
Introduce enums for snmp auth and privacy algorithms
2d933ec 
Using enums is safer and easier to extend.
@bjoernricks
Add credential type for password only
343ca05 
Allow to create password only credentials in GMPv8

Closes #96
@bjoernricks
Override create and modify filter in Gmpv8
d28ddce 
* The make_unique argument got dropped from create_filter
* Add a FilterType enum
@bjoernricks
Add new filter types for GMPv8
2b98bf5 
GMPv8 adds filter types for host, operating system, ticket and
vulnerability

Related to #97
@bjoernricks
Override create_target in Gmpv8
fcd342b 
Drop the make_unique argument from create_target because it got dropped
from the protocol too.

Fixes #97
@codecov
Copy link

codecov bot commented Jun 18, 2019 •
edited

Codecov Report

Merging #133 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   96.56%   96.65%   +0.08%     
==========================================
  Files          10       10              
  Lines        2564     2631      +67     
==========================================
+ Hits         2476     2543      +67     
  Misses         88       88
Impacted Files Coverage Δ
gvm/protocols/gmpv8.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d6abd...14826ab. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review June 18, 2019 13:52
@bjoernricks bjoernricks requested review from a team and wiegandm June 18, 2019 13:52
@bjoernricks @wiegandm
Fix typo
14826ab 
Co-Authored-By: Michael Wiegand <wiegandm@users.noreply.github.com>
@bjoernricks bjoernricks merged commit db2bdb5 into greenbone:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjoernricks @wiegandm