Improve types #139
Merged
Improve types #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add python type hints (https://docs.python.org/3/library/typing.html) and several enum (https://docs.python.org/3/library/enum.html) classes. At the end all type parameters will require an enum class instance.
Also add docstrings to all enum classes.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 96.75% 95.14% -1.62%
==========================================
Files 10 10
Lines 2714 2821 +107
==========================================
+ Hits 2626 2684 +58
- Misses 88 137 +49
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 96.75% 96.72% -0.04%
==========================================
Files 10 10
Lines 2714 3054 +340
==========================================
+ Hits 2626 2954 +328
- Misses 88 100 +12
Continue to review full report at Codecov.
|
Support original string values.
Use the type for create_port_range
Remove the type of the filter_type argument. The type will be derived from the type hint now.
Use the new enum in create_scanner and modify_scanner
Use the enum in create_schedule and modify_schedule
Use AliveTest in create_target and modify_target.
Use the enum in create_task and modify_task
Use the enum for get_asset and get_assets
Use this enum for getting a single credential in get_credential.
Use it for get_feed
* Drop credential_type arg. It is not possible to change the type of a credential. * Add type hints * Use SnmpAuthAlgorithm and SnmpPrivacyAlgorithm enums
It is not possible to change the credential type.
Use InfoType in get_info and get_info_list.
Add an enum class for all entity types. We are not very consistent where which type is allowed. Therefore list all "types" in this enum instead of mapping os, host to assets and cve, cpe, ... to info.
Only allow os and operating_system.
jjnicola
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: