Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gmp selection class #186

Merged
merged 5 commits into from Dec 9, 2019
Merged

Update Gmp selection class #186

merged 5 commits into from Dec 9, 2019

Conversation

bjoernricks
Copy link
Member

@bjoernricks bjoernricks commented Dec 7, 2019

Split the context manager enter method into several distinc methods.

Checklist:

@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #186 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   91.24%   91.38%   +0.14%     
==========================================
  Files          12       12              
  Lines        1017     1022       +5     
==========================================
+ Hits          928      934       +6     
+ Misses         89       88       -1
Impacted Files Coverage Δ
gvm/protocols/gmp.py 100% <100%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ca013...e63fcc5. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review December 7, 2019 17:56
y0urself
y0urself previously approved these changes Dec 8, 2019
@bjoernricks
Copy link
Member Author

Some tests should be added as always ...

@bjoernricks bjoernricks merged commit 3b54043 into greenbone:master Dec 9, 2019
@bjoernricks bjoernricks deleted the extend-gmp-selection-class branch March 31, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants