Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of EntityType AGENT #190

Merged
merged 3 commits into from Dec 17, 2019
Merged

Fix value of EntityType AGENT #190

merged 3 commits into from Dec 17, 2019

Conversation

wiegandm
Copy link
Member

@wiegandm wiegandm commented Dec 17, 2019

The value of EntityType.AGENT in the various GMP protocols was note, but should be agent.

Checklist:

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          12       12           
  Lines        1022     1022           
=======================================
  Hits          934      934           
  Misses         88       88
Impacted Files Coverage Δ
gvm/protocols/gmpv8/types.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv7/types.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv9/types.py 94.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1043c8e...3834ffb. Read the comment docs.

@wiegandm wiegandm marked this pull request as ready for review December 17, 2019 11:01
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernricks bjoernricks merged commit 0226d91 into greenbone:master Dec 17, 2019
@wiegandm wiegandm deleted the fix_entity_type_agent_enum branch December 17, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants