Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the details parameter to get_tls_certificate(s) #293

Merged
merged 3 commits into from Sep 18, 2020

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Sep 18, 2020

What:

Added the details parameter to the get_tls_certificate(s) functions.

Why:

The details parameter returns much more information for the Certificates as the include_certificate_data parameter.
See #292 for more information.

How:

Checklist:

@y0urself y0urself requested a review from a team as a code owner September 18, 2020 09:43
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #293 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   96.98%   96.99%           
=======================================
  Files          18       18           
  Lines        3953     3956    +3     
=======================================
+ Hits         3834     3837    +3     
  Misses        119      119           
Impacted Files Coverage Δ
gvm/protocols/gmpv9/gmpv9.py 97.17% <ø> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bffcd8...af012f6. Read the comment docs.

@y0urself y0urself merged commit c3dfb78 into greenbone:master Sep 18, 2020
@y0urself y0urself deleted the add-details-to-tls-getters branch May 20, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants