Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_nvt command requests all details #348

Merged
merged 3 commits into from Nov 26, 2020

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Nov 26, 2020

What:

Why:

Right now getting a single nvt from hyperion will give null preferences, timeout, preferenceCount, etc. This should fix the problem.

How:

Checklist:

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #348 (330fbdb) into master (4f3f3b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          20       20           
  Lines        4243     4246    +3     
=======================================
+ Hits         4136     4139    +3     
  Misses        107      107           
Impacted Files Coverage Δ
gvm/protocols/gmpv7/gmpv7.py 99.15% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3f3b2...330fbdb. Read the comment docs.

@saberlynx saberlynx changed the title get_nvt command requests preferences get_nvt command requests all details Nov 26, 2020
@saberlynx saberlynx marked this pull request as ready for review November 26, 2020 09:42
@saberlynx saberlynx requested a review from a team as a code owner November 26, 2020 09:42
@y0urself y0urself merged commit 8870ae1 into greenbone:master Nov 26, 2020
@saberlynx saberlynx deleted the nvt_preferences branch November 26, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants