Cite command error handling #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not exit program when a citation_to_citeproc lookup fails. Instead set a nonzero exit code, but proceed with passing citaitons. Error messages are logged, full stacktrace is logged at INFO level.
dhimmel
force-pushed
the
cite-command-errors
branch
from
ad80b03
to
d13aea9
Compare
|
@slochower I requested a review from you, since I think you know the citation infrastructure somewhat (?) and I was hoping to take some of the reviewer burden off of @agitter. |
|
Sure! Will take a look tomorrow. |
slochower
approved these changes
Oct 24, 2018
|
Hmm... I only see one line changed to a |
|
Yeah it is a small change, but we try to have every PR get reviewed unless it's extremely urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not exit program when a citation_to_citeproc lookup fails. Instead set a nonzero exit code, but proceed with passing citaitons. Error messages are logged, full stacktrace is logged at INFO level.