-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_pmc_citeproc: switch to Literature Citation Exporter #80
Conversation
NCBI Citaiton Exporter was taken offline without notice: https://twitter.com/dhimmel/status/1061787168820092929
@agitter this should take precedence over other PRs, since currently any Currently this PR only switches Once merged, we should update rootstock and release Manubot 0.2.1 (I will start preparing release notes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we want to merge this quickly, so I would be okay merging as-is. However, the error message for an invalid identifier that begins with PMC and an empty or non-numeric suffix is not very informative.
$ manubot cite pmcid:PMC
## ERROR
'PMCID'
[]
## CRITICAL
Failure: exiting with code 1 due to logged errors
Other bad example cases include pmcid:PMCA
and pmcid:PMC123A
. The API provides a different response for invalid numeric identifiers, like pmcid:PMC3
, which is caught and explained well by Manubot.
Ah interesting. When querying {
"status": "error",
"reason": {
"id": [
[
"This field is required."
]
]
}
} However, when querying an invalid id such as <pub-one-record-set xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:p1="http://pubmed.gov/pub-one" p1:error="PubOne failure: empty XML."/> |
@agitter I made the error checking and messaging more robust. Take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this version looks great. I tested with PMC0
, PMC1
, and PMCA
to see the various error handling paths.
NCBI Citaiton Exporter was taken offline without notice:
https://twitter.com/dhimmel/status/1061787168820092929