Balazs separate functions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubudibu
requested changes
Feb 15, 2017
web/src/app/router.js
Outdated
| @@ -0,0 +1,41 @@ | |||
| 'use strict'; | |||
|
|
|||
| const konnektApp = angular.module('konnektApp', ['ngRoute']); | |||
There was a problem hiding this comment.
this creates a new konnektApp module instead of using the existing one, remove the second parameter from the module method
web/src/app/router.js
Outdated
| } | ||
| }); | ||
| }]); | ||
| // })(); |
There was a problem hiding this comment.
you can put this one too in an IIFE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one monster file has been divided into 8 files + app.js