Bsoptei append user data #2
Conversation
|
@adamgyulavari /login and /register endpoints are ready to go (needs fine tuning but ready to connect with front end) |
| // getContext(). | ||
| // getAuthentication(). | ||
| // getName(); | ||
| // } |
There was a problem hiding this comment.
@bsoptei remove commented code
| public ResponseEntity generateResponse() { | ||
| return new ResponseEntity<>("", createResponseHeaders(), HttpStatus.BAD_REQUEST); | ||
| } | ||
| } |
There was a problem hiding this comment.
@bsoptei why different classes for creating a ResponseEntity?
the ResponseEntity should be created in the controller, just the first parameters should be defined as different response objects: eg. ContactListResponse, EmptyResponse, SingleContactResponse, etc...
These should be simple classes that can be serialized by the default serializer.
There was a problem hiding this comment.
ok, fixed it,
crud responses need fine tuning though.
but /login and /register are cool
going to push soon
| * Created by BSoptei on 2/1/2017. | ||
| */ | ||
| public class ListedItemsResponse extends CustomServerResponse { | ||
| private String body; |
There was a problem hiding this comment.
@bsoptei not string body here, but a List<Contact>
There was a problem hiding this comment.
currently it is converted into a String from a List (this is one type of a solution for the do-not-display-all-user-data problem)
There was a problem hiding this comment.
btw. we also tried with the @JsonIgnore annotation in the User class but it did not work
| URI location = URI.create("https://raptor-konnekt.herokuapp.com"); | ||
| responseHeaders.setLocation(location); | ||
| responseHeaders.set("session_token",token); | ||
| return responseHeaders; |
There was a problem hiding this comment.
@bsoptei you can call the defaults using super.createResponseHeaders()
There was a problem hiding this comment.
I tried but it won't allow me to
call the responseHeaders.set("session_token",token)
I was going to do it with the getHeaders().set("session_token", token) approach but it's not allowed
No description provided.