fix(registry-change): prioritize dependencies over all other depend…

…ency types

see #409

jobs/registry-change.js

@@ -62,8 +62,24 @@ module.exports = async function (
     '_id'
   )
 
-  return packages
+  // Prioritize `dependencies` over all other dependency types
+  // https://github.com/greenkeeperio/greenkeeper/issues/409
+
+  const order = {
+    'dependencies': 1,
+    'devDependencies': 2,
+    'optionalDependencies': 3
+  }
+
+  const sortByDependency = (packageA, packageB) => {
+    return order[packageA.value.type] - order[packageB.value.type]
+  }
+
+  const filteredSortedPackages = packages
     .filter(pkg => pkg.value.type !== 'peerDependencies')
+    .sort(sortByDependency)
+
+  return _.sortedUniqBy(filteredSortedPackages, pkg => pkg.value.fullName)
     .map(pkg => {
       const account = accounts[pkg.value.accountId]
       const plan = account.plan

test/jobs/registry-change.js

@@ -146,6 +146,45 @@ test('registry change create jobs', async t => {
     tt.is(newJobs.length, 0, 'no new jobs')
     tt.end()
   })
+
+  t.test('registry change updates dependencies if duplicated as devDependencies', async tt => {
+    tt.plan(2)
+    await repositories.put({
+      _id: '775',
+      enabled: true,
+      type: 'repository',
+      fullName: 'owner/repo3',
+      accountId: '999',
+      packages: {
+        'package.json': {
+          dependencies: {
+            eslint: '1.0.0'
+          },
+          devDependencies: {
+            eslint: '1.0.0'
+          }
+        }
+      }
+    })
+
+    const newJobs = await worker({
+      name: 'registry-change',
+      dependency: 'eslint',
+      distTags: {
+        latest: '10.0.0'
+      },
+      versions: {
+        '10.0.0': {
+          gitHead: 'b75aeb3'
+        }
+      },
+      registry: 'https://skimdb.npmjs.com/registry'
+    })
+
+    tt.is(newJobs.length, 1, 'one new jobs')
+    tt.is(newJobs[0].data.type, 'dependencies')
+    tt.end()
+  })
   t.end()
 })
 
@@ -156,6 +195,7 @@ tearDown(async () => {
   await repositories.remove(await repositories.get('888'))
   await repositories.remove(await repositories.get('777'))
   await repositories.remove(await repositories.get('776'))
+  await repositories.remove(await repositories.get('775'))
   await npm.remove(await npm.get('standard'))
   await npm.remove(await npm.get('eslint'))
 })