Optional $options parameter for the SQLParser #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 21, 2016 15:55
…ing able to output sub_tree expressions consistently as an array of arrays in MULTIPLE_PARAM_PARENTHESIS expression
|
Hi, Thank you very much for the contribution. I wasn't actually asking you to do the work, I was just trying to be funny :) |
|
I know, I just needed it to be done, funny or not :) Thanks for the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I understood the code correctly, but in my opinion the ONE and TWO in the *_PARAM_PARAMETERS are consistent comparing to all the other sub tree handling, so I just optionally modified the MULTIPLE branch.
I hope this is what was meant in #207 . Regarding the passing of the object - I didn't want to make it statically accessible, because it would change state of all the SQLParser instances globally, which I'm not sure if that would be a good idea.