Cleanup

- Anon classes with lambdas
- Unused declared exceptions
- Spelling

greenmail-core/src/main/java/com/icegreen/greenmail/base/GreenMailOperations.java

@@ -70,7 +70,7 @@ public interface GreenMailOperations {
     boolean waitForIncomingEmail(int emailCount);
 
     /**
-     * @return Returns all messags in all folders for all users
+     * @return Returns all messages in all folders for all users
      * {@link com.icegreen.greenmail.util.GreenMailUtil} has a bunch of static helper methods to extract body text etc.
      */
     MimeMessage[] getReceivedMessages();

greenmail-core/src/main/java/com/icegreen/greenmail/configuration/PropertiesBasedGreenMailConfigurationBuilder.java

@@ -95,7 +95,7 @@ protected String buildLocalPartLogin(String localPart, String domain) {
 
     protected void extractAndAddUser(GreenMailConfiguration configuration, BinaryOperator<String> buildLogin, String user) {
         // login:pwd@domain
-        String[] userParts = user.split(":|@");
+        String[] userParts = user.split("[:@]");
         switch (userParts.length) {
             case 2:
                 configuration.withUser(userParts[0], userParts[1]);

greenmail-core/src/main/java/com/icegreen/greenmail/imap/ImapRequestHandler.java

@@ -20,8 +20,8 @@
  */
 public final class ImapRequestHandler {
     protected final Logger log = LoggerFactory.getLogger(getClass());
-    private ImapCommandFactory imapCommands = new ImapCommandFactory();
-    private CommandParser parser = new CommandParser();
+    private final ImapCommandFactory imapCommands = new ImapCommandFactory();
+    private final CommandParser parser = new CommandParser();
     private static final String REQUEST_SYNTAX = "Protocol Error: Was expecting <tag SPACE command [arguments]>";
 
     /**

greenmail-core/src/main/java/com/icegreen/greenmail/imap/ImapResponse.java

@@ -19,7 +19,7 @@
  * to the client.
  */
 public class ImapResponse implements ImapConstants {
-    private InternetPrintWriter writer;
+    private final InternetPrintWriter writer;
     private String tag = UNTAGGED;
 
     public ImapResponse(OutputStream output) {