Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jakarta.mail 2.0 #317

Closed
uberskigeek opened this issue Jun 3, 2020 · 12 comments
Closed

Add support for jakarta.mail 2.0 #317

uberskigeek opened this issue Jun 3, 2020 · 12 comments
Assignees
Milestone

Comments

@uberskigeek
Copy link
Contributor

  • Maven dependencies
  • Javadoc links (pom.xml)
  • Check release note for further actions
    Jakarta 2.0 has renamed the javax.mail packages to jakarta.mail along with some enhancements.
@marcelmay marcelmay self-assigned this Jul 30, 2020
@marcelmay marcelmay added this to the 2.0 Draft milestone Jul 30, 2020
@marcelmay
Copy link
Member

Thx, @uberskigeek .

Pulled the PR into branch issue-317-jakarta-mail-2-0.

@oliverlietz
Copy link

Can we have an early 2.0 release with jakarta.mail, please?

@Airblader
Copy link

@marcelmay First off, thanks for this great project! I'd really love to use GreenMail for automated tests, but this would force me to downgrade, which I'd like to avoid.

Would you mind elaborating what the current situation / issues are since a branch does seem to exist? Can we help somehow?

@marcelmay
Copy link
Member

@Airblader , I'll try to tackle that over upcoming easter vacation.

I try to keep GreenMail and JakartaMail major/minor versions in sync, and for a GreenMail 2.0 I'd like to use the chance to cleanup and deprecate some features. But an 2.0 pre release candidate for easter should work out.

@Airblader
Copy link

That makes sense. Thanks for the response, looking forward to it!

marcelmay pushed a commit that referenced this issue Apr 2, 2021
- Pulled from https://github.com/uberskigeek/greenmail/commits/317_jakarta_mail_2.0
- Rebased on master
- Updated to latest JakartaMail 2.0
- Update GreenMail version to 2.0.0-SNAPSHOT
@marcelmay
Copy link
Member

I created a new release 2.x preview branch, which contains the pulled in Jakarta Mail 2.0 changes rebased on latest master.

@RaphaelJenni
Copy link

@marcelmay Thanks a lot for the project and for keeping it alive!

Regarding the 2.x version with the jakarta.mail 2.0 support. Is it possible for you to release a beta/preview version to maven? This way we wouldn't have to build it manually and include it as a jar into our project.

@marcelmay marcelmay modified the milestones: 2.0 Draft, 2.0.0-alpha-1 Apr 5, 2021
@marcelmay
Copy link
Member

@RaphaelJenni , just released an 2.0.0-alpha-1 for you. Any feedback appreciated.

@marcelmay
Copy link
Member

@uberskigeek , thx alot for this PR. Sorry it took some time, now it is the base for GreenMail 2.0

@michaelhixson
Copy link

2.0.0-alpha-1 looks good in my app's tests. Thanks.

@RaphaelJenni
Copy link

@marcelmay thanks a lot for the alpha release. So far all tests are running as expected.

Only thing I had to add was the implementation("jakarta.activation:jakarta.activation-api:2.0.1") dependency for solving the NoClassDefFoundError: jakarta/activation/DataSource (Maven Repo) error.

@marcelmay
Copy link
Member

@RaphaelJenni , thx for the feedback. This will be fixed by #385 .

The jakarta.activation-api should be added, as also GreenMailUtil imports API classes.

It seems com.sun.mail:jakarta.mail transitively pulls in com.sun.activation:jakarta.activation, which contains both activation and activation-api ... so a NCDFE should not happen. Anyway, dependency will be added.

marcelmay pushed a commit that referenced this issue Jun 13, 2021
- Pulled from https://github.com/uberskigeek/greenmail/commits/317_jakarta_mail_2.0
- Rebased on master
- Updated to latest JakartaMail 2.0
- Update GreenMail version to 2.0.0-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants