Don't include one extra space after 334 response #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It trips some clients up and is not according to spec.
|
Actually, the use of |
|
Thx alot, @gregopet ! |
|
Happy to have helped, and indeed happy that I was able to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SMTP_SERVER_CONTINUATION constant already contains a space at the end and there is even a comment warning about that next to its definition.
It trips some clients up (Vert.x Mail client in my case) and is not according to spec which says
"334" SP [base64] CRLF(looking at https://tools.ietf.org/html/rfc4954#ref-SASL).