Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Remove domain from cookie #107

Closed
TtheBC01 opened this issue May 17, 2022 · 4 comments
Closed

feature: Remove domain from cookie #107

TtheBC01 opened this issue May 17, 2022 · 4 comments
Assignees

Comments

@TtheBC01
Copy link

Continued from issue #106

For reference, here is a trace:

{
   "level":"debug",
   "time":"2022-05-17T22:06:58.948Z",
   "msg":"debugging response",
   "request_id":"2be10c67-59b0-470c-b74d-1eec2bb32f86",
   "direction":"outgoing",
   "tag":"XYZ",
   "status_code":303,
   "response_size":0,
   "buffer_size":0,
   "response_headers":{
      "Cache-Control":[
         "no-store"
      ],
      "Location":[
         "https://density-why-judge-epinions.trycloudflare.com/auth/sandbox/H1bTYMvZQHS4TBkL2Yy68XHOze2mazwY0ONElbBO8K62Y"
      ],
      "Pragma":[
         "no-cache"
      ],
      "Server":[
         "Caddy"
      ],
      "Set-Cookie":[
         "AUTHP_SANDBOX_ID=PKc832f47HN4cc0t4RrBLQyedZAuYucx6WyGPFA7kD; Domain=trycloudflare.com; Path=/;"
      ]
   }
}
@greenpau
Copy link
Owner

@TtheBC01 , as discussed, would add a Caddyfile directive to remove domain from the issued cookies.

@greenpau
Copy link
Owner

@TtheBC01 , I am about to release new version.

Please add the following directive. The cookie strip domain would instruct the plugin to omit the injection of Domain into a cookie.

authentication portal <name> {
  cookie strip domain
}

Please test and let me know how it goes 😄

@TtheBC01
Copy link
Author

Just tried it out with the latest version of the plugin. Adding cookie strip domain works great, anonymous tunnels supported now. Updated login forms look nice too!

@greenpau
Copy link
Owner

Just tried it out with the latest version of the plugin. Adding cookie strip domain works great, anonymous tunnels supported now. Updated login forms look nice too!

@TtheBC01 , glad to hear that the guess was correct! 👍 Enjoy the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants