PLANET-5443 Add rollback target to Makefile #53
Conversation
Split deploy target into three (prepare, deploy, post), so these can be re-used for rollback. Rollback also checkouts code in order to run post-deploy scripts
comzeradd
changed the title
There was a problem hiding this comment.
Looks good 👍 Left a suggestion to have separate job steps with the new make targets but that would be for other repo's, maybe we could include it in https://github.com/greenpeace/planet4-nro-generator/pull/31/files
| # Rollback to the previous good release | ||
| ./helm_rollback.sh | ||
|
|
||
| deploy-helm: |
There was a problem hiding this comment.
Nice! Now that this is a separate target, maybe we could make prepare-helm deploy-helm post-deploy into separate job steps instead of a single one with the deploy target. Would make the job output easier to navigate.
There was a problem hiding this comment.
I can take that as a separate task, since this would require further changes at the CI templates, but it's a good point. We can break this up even further and also start using name: at our CI steps to make them less cryptic.
| @@ -270,6 +268,11 @@ endif | |||
| --zone $(GCLOUD_ZONE) \ | |||
| --project $(GOOGLE_PROJECT_ID) | |||
|
|
|||
| rollback-helm: | |||
| # Rollback to the previous good release | |||
There was a problem hiding this comment.
Should work for staging as the previous one should be the one that's on production 👍 Is there a way to find out exactly which version is on production so we can pass it explicitly?
There was a problem hiding this comment.
Helm will look specifically for the staging images, because it uses HELM_RELEASE from the env variables.
- Merge pull request #53 from greenpeace/rollback PLANET-5443 Add rollback target to Makefile [skip ci]
Split deploy target into three (prepare, deploy, post), so these can be re-used for rollback.
Rollback also checkouts code in order to run post-deploy scripts.