Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-2282 HANDBOOK: rework sitemap #21

Merged
merged 1 commit into from
Sep 3, 2020
Merged

PLANET-2282 HANDBOOK: rework sitemap #21

merged 1 commit into from
Sep 3, 2020

Conversation

dpivo
Copy link
Contributor

@dpivo dpivo commented Jul 9, 2020

  • override sitemap.php in handbook to apply changes

@dpivo dpivo requested review from a team, pablocubico and mleray and removed request for a team July 9, 2020 13:23
@comzeradd comzeradd requested review from Inwerpsel and removed request for pablocubico July 20, 2020 08:41
lithrel
lithrel approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@lithrel lithrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
If you have time, you can switch to our new class names :
P4_Post -> P4\MasterTheme\Post
P4_Sitemap -> P4\MasterTheme\Sitemap

@dpivo
Copy link
Contributor Author

dpivo commented Sep 3, 2020

@lithrel Done 👍

@comzeradd comzeradd merged commit 723d9d1 into master Sep 3, 2020
@comzeradd comzeradd deleted the planet-2282 branch September 3, 2020 16:48
@comzeradd comzeradd mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithrel lithrel lithrel approved these changes

@mleray mleray Awaiting requested review from mleray

@Inwerpsel Inwerpsel Awaiting requested review from Inwerpsel

Assignees
No one assigned
Labels
review & merge
Projects
None yet
Milestone
No milestone
3 participants
@dpivo @lithrel @comzeradd