Clean up Listing page code

- Remove unnecesary code
greenpeace · Jun 14, 2024 · c10af5b · c10af5b
1 parent 4e1b72a
commit c10af5b
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 16 deletions.
diff --git a/archive-p4_action.php b/archive-p4_action.php
@@ -19,5 +19,4 @@
 $context['custom_body_classes'] = 'tax-p4-page-type';
 $context['header_title'] = post_type_archive_title('', false);
 
-$page = new ListingPage($templates, $context);
-$page->view();
+new ListingPage($templates, $context);
diff --git a/author.php b/author.php
@@ -34,14 +34,7 @@
         'width' => '300',
         'height' => '300',
     ];
-
-    $author_share_buttons = new stdClass();
-    $author_share_buttons->title = $author->name;
-    $author_share_buttons->description = get_the_author_meta('description', $author->ID);
-    $author_share_buttons->link = $author->link;
-    $context['author_share_buttons'] = $author_share_buttons;
 }
 
 $templates = ['author.twig', 'archive.twig'];
-$page = new ListingPage($templates, $context);
-$page->view();
+new ListingPage($templates, $context);
diff --git a/index.php b/index.php
@@ -44,7 +44,6 @@
     array_unshift($templates, 'all-posts.twig');
 
     $page = new ListingPage($templates, $context);
-    $page->view();
 } else {
     Timber::render($templates, $context);
 }
diff --git a/src/ListingPage.php b/src/ListingPage.php
@@ -33,6 +33,7 @@ public function __construct(array $templates = [ 'archive.twig', 'index.twig' ],
         $this->context = $context;
 
         $this->update_context();
+        $this->view();
     }
 
     /**

diff --git a/tag.php b/tag.php
@@ -50,5 +50,4 @@
 rewind_posts();
 
 $templates = ['tag.twig', 'archive.twig', 'index.twig'];
-$page = new ListingPage($templates, $context);
-$page->view();
+new ListingPage($templates, $context);
diff --git a/taxonomy.php b/taxonomy.php
@@ -19,5 +19,4 @@
 $context['wp_title'] = $taxonomy->name;
 $context['og_description'] = $taxonomy->description;
 
-$page = new ListingPage($templates, $context);
-$page->view();
+new ListingPage($templates, $context);
diff --git a/templates/burger-menu-items.twig b/templates/burger-menu-items.twig
@@ -24,6 +24,7 @@
                     type="button"
                     data-bs-toggle="collapse"
                     data-bs-target="#menu-{{ targetId }}"
+                    aria-label="Nav Link Button"
                     aria-expanded="false"
                     aria-controls="menu-{{ targetId }}"></button>
             {% endif %}

diff --git a/templates/burger-menu.twig b/templates/burger-menu.twig
@@ -10,7 +10,6 @@
       {{ __( 'Close navigation mobile menu', 'planet4-master-theme' ) }}
     </span>
     </button>
-
     <div class="burger-menu-header">
         <a class="site-logo" href="{{ data_nav_bar.home_url }}">
             {% include "blocks/site_logo.twig" %}