PLANET-5388 Fix author bio translation on Post and Author page #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarsdeshmukh
requested review from
lithrel and
mleray
and removed request for
a team
lithrel
reviewed
Oct 20, 2020
templates/blocks/author_profile.twig
Outdated
| @@ -12,11 +12,12 @@ | |||
| {% endset %} | |||
|
|
|||
| {% set author_bio_char_limit = 180 %} | |||
| {% set post_author_description = fn('the_author_meta', 'description', post.author.id) %} | |||
There was a problem hiding this comment.
I think it's get_the_author_meta (missing get_) ? Doesn't return anything without it on my env
There was a problem hiding this comment.
yeah, actually it's working inside twig, but using get_the_author_meta () is more appropriate here 👍 ( In source code the the_author_meta() function internally calls the get_the_author_meta() function. )
sagarsdeshmukh
force-pushed
the
planet-5516-wpml-author-bio
branch
from
c9e6ce7
to
cce5331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel. to JIRA 5388
eg. https://k8s.p4.greenpeace.org/test-nix/fr/story/43917/quest-ce-que-le-lorem-ipsum-fr/