PLANET-5386 Force only related videos of channel #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inwerpsel
force-pushed
the
planet-5386
branch
from
635db41
to
6e2c4ed
Compare
lithrel
approved these changes
Dec 10, 2020
src/MasterSite.php
Outdated
|
|
||
| $replacements = [ | ||
| 'youtube.com' => 'youtube-nocookie.com', | ||
| 'feature=oembed' => 'feature=oembed&rel=0&', |
There was a problem hiding this comment.
I guess the last & is not necessary ? but it doesn't break anything 🤷
* For now this uses a somewhat shaky method of adding this, by replacing it in the embed html as a string and relying on the `feature=oembed` query parameter being there. Checking if there is a better way.
Inwerpsel
force-pushed
the
planet-5386
branch
from
6e2c4ed
to
ab1792d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add
rel=0query parameter to the iframe url. This is done in the same way as the youtube-nocookie, on the embed html response.For now this uses a somewhat shaky method of adding this, by relying on the
feature=oembedquery parameter being there. Checking if there is a better way, but I guess there's no risk proceeding with this in the meanwhile if it turns out to be tricky?Ref: https://jira.greenpeace.org/browse/PLANET-5386