Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dashdash, whitelist shorthand #1320

Merged
merged 1 commit into from Mar 1, 2021
Merged

Bump dashdash, whitelist shorthand #1320

merged 1 commit into from Mar 1, 2021

Conversation

Inwerpsel
Copy link
Contributor

@Inwerpsel Inwerpsel commented Mar 1, 2021

Ref: no ticket, just a bump to match the same bump in greenpeace/planet4-plugin-gutenberg-blocks#495


This bumps dashdash to the latest version, which supports a shorthand to generate variable names from the selector.

.foo-bar {
  _-- {
    color: green;
    background-color: yellow;
  }
}

produces the same result as

.foo-bar {
  --foo-bar-- {
    color: green;
    background-color: yellow;
  }
}

which is the same as

.foo-bar {
  color: var(--foo-bar--color, green);
  background-color: var(--foo-bar--background-color, yellow);
}

Copy link
Member

@comzeradd comzeradd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust also Sonacloud stylelint config if needed?

@Inwerpsel Inwerpsel merged commit a5fb218 into master Mar 1, 2021
@Inwerpsel Inwerpsel deleted the bump-dashdash branch March 1, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants