New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-6387 Allow import/export for all post types #1447
Conversation
/unhold cc36dc18-b5e3-4407-90c5-e1b68e4399c8
Test instance is ready 🚀🌑 tavros | admin | blocks report | CircleCI | composer-local.json ⌚ 2022.01.18 12:55:48 |
30905d1
to
850e042
Compare
/unhold 275f8e26-b7da-44c7-9910-10f59133f5ac
850e042
to
7fc758d
Compare
/unhold eafd4a95-efbe-4d7d-aac2-52b4bcb42301
7fc758d
to
faeab8e
Compare
/unhold d0601b6b-6cd0-4524-916f-bee716d26c93
faeab8e
to
4729c61
Compare
/unhold 2bf0fddb-a3a7-4ec6-9cbb-65ca8cd5ab0c
Ref: https://jira.greenpeace.org/browse/PLANET-6387 * Remove all checks for the "campaign" post type, as this logic should work on other types as well. This way workarounds are no longer needed to import other types.
Ref: https://jira.greenpeace.org/browse/PLANET-6387 * I don't understand how the base import doesn't include this in the output.
4729c61
to
f2c485f
Compare
/unhold 1040dd45-af7d-4f11-8d96-61abfdf55138
Can we also change the files names? 🤔 |
@@ -8,8 +8,8 @@ | |||
|
|||
class_alias( \P4\MasterTheme\Activator::class, 'P4_Activator' ); | |||
class_alias( \P4\MasterTheme\AnalyticsValues::class, 'P4_Analytics_Values' ); | |||
class_alias( \P4\MasterTheme\CampaignExporter::class, 'P4_Campaign_Exporter' ); | |||
class_alias( \P4\MasterTheme\CampaignImporter::class, 'P4_Campaign_Importer' ); | |||
class_alias( \P4\MasterTheme\Exporter::class, 'P4_Campaign_Exporter' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove these aliases, might do that in a follow up.
/unhold ff31691a-8c98-42ea-9e8f-09b9ec81bd2b
Other than taxonomy import issue PR looks good to me 👍 |
Ref: https://jira.greenpeace.org/browse/PLANET-6387 * It works for all types now. * Preserve it on function that truly only relates to campaigns.
fafbdc9
to
e88a064
Compare
/unhold 66b3c329-6479-434c-91a0-c3824d3cbd6d
I agree that importing taxonomy, will be quite challenging. |
Ref: https://jira.greenpeace.org/browse/PLANET-6387
Remove all checks for the "campaign" post type, as this logic works on other types as well.
Makes following things appear in the UI which were only on campaign pages previously:
Otherwise the import is functionality that didn't need any further changes to work on all post types.
I took the liberty to also add an edit link to the post import output if it's successful. I imagine people will often want to edit it after import.