Maintenance: move REST_NAMESPACE const to BaeBlock PHP class #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It helps to avoid duplicating code
planet-4
added a commit
to greenpeace/planet4-test-iocaste
that referenced
this pull request
Jan 18, 2024
/unhold dda3b87f-a2e7-40b4-8f6c-e74cd3ad2d0b
Test instance is ready 🚀🌑 iocaste | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.01.18 19:39:55 |
GP-Dan-Tovbein
deleted the
move-rest-namespace-const-to-base-block-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[No ticket needed]
Description
This small change is because to avoid repeated code and easy to maintain. The
REST_NAMESPACEconstant is being used, at least, by two different blocks. These are the Spreadsheet and the Happypoint.