PLANET-7542: Remove from plugin the blocks that have been moved to the theme #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GP-Dan-Tovbein
force-pushed
the
PLANET-7542_remove-blocks-moved-to-theme
branch
from
19e0afa
to
2a83f79
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 19, 2024
/unhold 8f33ef6c-11a9-48c0-bf50-68d9ef189c75
Test instance is ready 🚀🌑 umbriel | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.23 18:32:24 |
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 19, 2024
/unhold 69f47ccb-47dd-4c29-96eb-bb322bb3375f
- It includes all related files
GP-Dan-Tovbein
force-pushed
the
PLANET-7542_remove-blocks-moved-to-theme
branch
from
5407306
to
aaf9bb6
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 22, 2024
/unhold 174d8040-618d-427e-aaed-568c10795285
Update specs or migrations if required Update text
GP-Dan-Tovbein
force-pushed
the
PLANET-7542_remove-blocks-moved-to-theme
branch
from
aaf9bb6
to
8b4663a
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 22, 2024
/unhold bf30746e-1f26-45a2-98ed-9d8b2d7a62ba
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 22, 2024
/unhold b585bb2c-f72e-478f-a04b-704a14036d52
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 22, 2024
/unhold 45e99af0-8e8c-4e2d-81d0-c56665fd15e0
- Next step is to fix them warnings
- Include all related files
GP-Dan-Tovbein
force-pushed
the
PLANET-7542_remove-blocks-moved-to-theme
branch
from
da0b6de
to
eab1397
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 22, 2024
/unhold bef87847-0b4f-4d17-8df1-4bc6f36ff9f9
- Fix eslint files
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 23, 2024
/unhold 912b42cd-6471-476f-9633-48a73d6c4e57
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 23, 2024
/unhold d5eac0d0-3f54-4df1-a628-f847b6da4ae6
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 23, 2024
/unhold c3530768-1962-4c5d-a6f0-d14a802fcb31
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 23, 2024
/unhold ab146eab-6fea-4971-85ed-ea51601d41de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-7542
Description
Changed the initial scope for the ticket. The new requirement is to move all missing specs from plugin. Indeed migrations if they are needed.
I created a new directory
test/blocksand include all block specs instead of the root directory which is how it's now added into the plugin.You can see the list of blocks that were already moved into the theme as a part of the
monorepoepic.Testing
From dev, you can run
npm run env:e2eOr indivudally through
npx playwright test tests/e2e/blocks/{{filename}}.spec.jsI've disabled the Planet4 - Gutenberg Blocks to make sure that all is properly working without it.
If the plugin is disabled (test instance):
24 failed1 flaky15 skipped42 passed24 failed15 skipped43 passedLocal dev test cases
If the plugin is disabled
33 failed18 skipped31 passedIf the plugin is enabled BUT keeping this piece of code and this other one.
33 failed18 skipped31 passedIf the plugin is enabled BUT removing this piece of code and this other one.
33 failed18 skipped31 passed