Planet 2561

[onyekaa]

Master branch of all changes made for Planet 2561. Merged in the deploy branch.
Changes include:

• Exporter functionality
• The metaboxes for campaign theming
• The Campaign post type twig and php files.

[comzeradd]

This has similar issues with the plugin-blocks PR. It's full with fixup commits and merge commits from the target branch.

I see this is still WIP. But when it's ready to be merged, we should spend some time to clean up the commits.

[onyekaa]

@comzeradd I'm basically done with it. You want me to squash just the merge commits? Or which other ones?

[comzeradd]

The merge commits that were created as part of merging PRs to this branch are fine. The ones that shouldn't be there are ones that merge the target branch back into this. (eg. Merge branch 'develop' into planet-2561).

Additionally the PR has many fixup commits (eg. Linter fixes, Formatting fixes, etc). In general we avoid having commits that fix syntax, linting, typo errors that were introduced on previous commits of the same PR.

[kirdia]

Ideally these commits (to which Nikos is referring to) should not exist as they pollute the git history
For example these commits
commit 2d6d2ea
commit 0c72f63
commit e61ffa5 (pull/703)

As this is an evolving codebase, we need to keep the git history as clean as possible.
And while these commits have some value during the lifeline of the branch/feature development they don't have any value for us after the feature is completed and merged and makes it harder to maintain the code.

[comzeradd]

Closing this in favor of #751