Planet-2561 - Added customizations for campaign post types #445
Conversation
onyekaa
changed the title
|
I've merged develop into this branch due to the changes made that cause conflicts with the work done so far. All theme styles and images from outlandish have been added in this PR. |
| @@ -2,6 +2,7 @@ | |||
| @import "base/variables"; | |||
| @import "base/functions"; | |||
| @import "base/mixins"; | |||
| @import "base/blocks"; | |||
There was a problem hiding this comment.
This is a rather huge file. This should probably needs to break down into smaller components.
There was a problem hiding this comment.
Hi. How do you suggest I split them? By block types?
There was a problem hiding this comment.
Yes, but as far as I can see this includes blocks that already exist. So the code should be split into the right components.
You use mixins to redefine some existing blocks, creating a lot of code repetition. It's not clear to me why this approach was chosen to suggest an alternative. But this will make the blocks prone to regression bugs if we need to do any change in the future. Maybe define the mixins right in their existing component, with some default values that you can override when you include them for the campaigns.
There was a problem hiding this comment.
I didn't write this, this is the code gotten from Outlandish, so maybe we can discuss this with them?
There was a problem hiding this comment.
Hey guys, re the approach taken for the campaign styles ... my understanding is that we were provided with flat html and css for a showcase mock-up page and were asked to write css to apply the new designs to this html without altering the html or base css. This was before we were involved with working on the planet4 blocks plugin itself. Hope that's helpful?
| @@ -187,3 +187,97 @@ $nested-comment-left-margin: $n50; | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @mixin monochrome { | |||
There was a problem hiding this comment.
Let's avoid adding a new set of media queries mixins. You can use the ones already in place and adjust your code to be mobile first.
|
@comzeradd squashing commits is usually quite a painful exercise, it moves us backwards in testing, and we can't invest continuous development time. Could you either jump in and do this yourself or we commit as is. |
Reverted slug. Style fixes for cover blocks, removed imports. Moved font imports and recompiled css
|
@mcshanea this is a standard review process for opening and merging PRs. Squashing would have been avoided if the feature branch was initially rebased, instead of merging. We can't really merge a PR with merge commits from the target branch. See the git best practices that we tend to follow on planet4 (especially the "Amend" and "Rebase" parts). |
|
@comzeradd Commits have been squashed. |
PLANET-3379: Break down the blocks.css of the campaigns site to smaller parts
|
Closing this in favor of #526 |
Ref: https://jira.greenpeace.org/browse/PLANET-2561