This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
PLANET-3201 - Using CSS columns rather than flexbox for submenu layout #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koyan
changed the title
|
Note: This should complete the work at PLANET-3072 |
koyan
changed the title
|
|
comzeradd
force-pushed
the
submenu-columns-vertical
branch
from
75d6d73
to
f67a7bf
Compare
|
@comzeradd Thanks for sorting! This branch has been superseded by this and could be deleted btw https://github.com/greenpeace/planet4-plugin-blocks/tree/submenu-design-update |
|
Done, branch (And other stale ones) deleted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Gabor asked us to address the issue whereby submenu items are ordered left-to-right first, rather then top-to-bottom, when they appear in columns, e.g. here: https://www.greenpeace.org/international/explore/about/worldwide/
This PR uses CSS columns instead of flex to ensure they are ordered top-to-bottom first.
(As was suggested by Tam in his original PR here: #440)