Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-7153: Follow up Wordpress 6.2 deprecations #1042

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

GP-Dan-Tovbein
Copy link
Contributor

@GP-Dan-Tovbein GP-Dan-Tovbein commented Apr 24, 2023

Ref: https://jira.greenpeace.org/browse/PLANET-7153

Description

Since we're about to upgrade to WordPress 6.2 “Dolphy” we would need to make sure our code is up to date with the new requirements. Some of them has been deprecated since WordPress 6.1 “Misha”.

The current PR should be merged after

Testing

Make sure to run Wordpress 6.2 on your local.

@GP-Dan-Tovbein GP-Dan-Tovbein self-assigned this Apr 24, 2023
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from a9df172 to 8d7fe53 Compare April 24, 2023 12:27
planet-4 added a commit to greenpeace/planet4-test-iocaste that referenced this pull request Apr 24, 2023
/unhold 6e3a3093-9ad0-44d3-b10f-9b4c838dd60f
@GP-Dan-Tovbein GP-Dan-Tovbein marked this pull request as draft April 24, 2023 12:32
@GP-Dan-Tovbein GP-Dan-Tovbein assigned mleray and unassigned mleray Apr 24, 2023
@GP-Dan-Tovbein GP-Dan-Tovbein changed the title Follow up wordpress 6.2 deprecations Follow up Wordpress 6.2 deprecations Apr 24, 2023
@planet-4
Copy link
Contributor

planet-4 commented Apr 24, 2023

Test instance is ready 🚀

🌑 rhea | admin | blocks report | CircleCI | composer-local.json

⌚ 2023.08.23 13:28:51

@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from 4f27fec to d803524 Compare April 24, 2023 13:37
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Apr 24, 2023
/unhold 55642627-cee0-424b-b3ab-a0531d5c29f4
@GP-Dan-Tovbein GP-Dan-Tovbein marked this pull request as ready for review April 24, 2023 13:53
Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we include the changes from this PR into this one? 🤔

@GP-Dan-Tovbein
Copy link
Contributor Author

Shouldn't we include the changes from this PR into this one? 🤔

TBH, I don't believe these changes are 100% related to #1039, but yes to greenpeace/planet4-base#244

planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Apr 25, 2023
/unhold 249cbd77-8821-418c-8ad5-befb38057b6b
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Apr 25, 2023
/unhold 56dbefbd-73ea-4314-8f9d-00eacbe897cf
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Apr 25, 2023
/unhold f6473d6a-d38d-49bf-919b-7b230d213755
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Apr 26, 2023
/unhold 77aec18b-0492-4aa8-be7d-09eeb8a3e7a4
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from fde8a7c to 51401b5 Compare May 8, 2023 12:14
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request May 8, 2023
/unhold e366f99f-d0fe-4fa7-8168-e571ffdbed40
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from 51401b5 to 65af8cd Compare May 8, 2023 12:35
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request May 8, 2023
/unhold 296c15bb-ce10-4226-8288-c5a8975a4d5b
@GP-Dan-Tovbein GP-Dan-Tovbein requested a review from mleray May 8, 2023 12:58
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request May 8, 2023
/unhold 802e00db-3f0f-43c0-b958-58a4b9da998b
@GP-Dan-Tovbein GP-Dan-Tovbein changed the title Follow up Wordpress 6.2 deprecations PLANET-7153: Follow up Wordpress 6.2 deprecations May 10, 2023
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from 65af8cd to 8a4e973 Compare June 30, 2023 09:21
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jun 30, 2023
/unhold 41eed0c6-1de4-4826-9e04-d26ce7739beb
Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jun 30, 2023
/unhold 51822917-14f3-429b-bbcb-e25fdc42c25d
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jun 30, 2023
/unhold b344c9a8-64e7-4e32-8480-cd2c5ac21b2b
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Jul 3, 2023
/unhold e89565af-bd8d-4a9c-8a58-848a3d0c2442
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from 8a4e973 to e4be0ff Compare August 23, 2023 11:33
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Aug 23, 2023
/unhold ab451588-484e-4733-a6ec-9c4fb968d9f5
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Aug 23, 2023
/unhold 95ab46db-e8df-4f82-9c1a-8e071c21172e
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Aug 23, 2023
/unhold d10123a3-133d-4994-8e5d-ae1650ab8a9f
- Taken from @types/wordpress__components/button/index.d.ts line 15
- Taken from @types/wordpress__components/button/index.d.ts line 21
- ReactDOM.hydrate is no longer supported in React 18
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the follow-up-wordpress-6.2-deprecations branch from e4be0ff to 33f5d88 Compare August 23, 2023 13:04
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Aug 23, 2023
/unhold 2d31e0b6-fafc-4d36-9bb3-92eb262cc0b5
planet-4 added a commit to greenpeace/planet4-test-rhea that referenced this pull request Aug 23, 2023
/unhold c1777307-ba12-4b36-830f-1ff36a853719
@GP-Dan-Tovbein GP-Dan-Tovbein merged commit baf89cb into main Aug 23, 2023
14 checks passed
@GP-Dan-Tovbein GP-Dan-Tovbein deleted the follow-up-wordpress-6.2-deprecations branch August 23, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants