Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-6917 Refactor Counter block to use hydration #1099

Merged
merged 3 commits into from Sep 11, 2023
Merged

PLANET-6917 Refactor Counter block to use hydration #1099

merged 3 commits into from Sep 11, 2023

Conversation

mleray
Copy link
Contributor

@mleray mleray commented Aug 17, 2023 •
edited

Description

See PLANET-6917
This is to stop using the deprecated frontendRendered function. This PR also includes splitting the files for the Counter block.

Testing

You can check out different styles of the block now using hydration on local or on this page for example.

@mleray mleray self-assigned this Aug 17, 2023
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 17, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 295e7b2d
a3567af 
/unhold af971dfa-aeaa-4327-a0ff-5afa99faf60a
@greenpeace greenpeace deleted a comment from planet-4 Aug 17, 2023
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 17, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 0dbcc3f8
793e869 
/unhold 62e01809-142a-40f1-9556-698cc8227854
@greenpeace greenpeace deleted a comment from planet-4 Aug 17, 2023
@mleray mleray changed the title Refactor Counter block PLANET-6917 Refactor Counter block to use hydration Aug 17, 2023
@mleray mleray marked this pull request as ready for review August 17, 2023 12:29
@mleray mleray added the Review label Aug 17, 2023
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 17, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at e2d09053
0c60090 
/unhold 6eeb8a8a-c9bf-4337-ab55-f0088be00863
@planet-4
Copy link
Contributor

planet-4 commented Aug 17, 2023 •
edited

Test instance is ready 🚀

🌑 janus | admin | blocks report | CircleCI | composer-local.json

⌚ 2023.09.11 10:33:50

planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 18, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 4379ef28
7900cbb 
/unhold 0c0d0ee7-c29c-4689-b082-893a5e5f42aa
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 18, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at bb18f820
8b4594c 
/unhold 3b3c31d1-cb11-40a5-a39c-50701f27a141
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 18, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at aaca254a
81afdef 
/unhold fd77f205-da7c-4e14-9ad2-0ba309088d9b
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 18, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at aaca254a
7ae77a4 
/unhold 0f69255e-31ef-452a-b2e8-0d5f5691d7c1
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 18, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at aaca254a
7f2325f 
/unhold 9d75b634-e573-4c13-a615-7754c4b8d46a
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 21, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at aaca254a
096452a 
/unhold 4d88d3df-bda8-4e8e-b478-01e91037e09e
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 21, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at b8f14065
1e6541f 
/unhold cc6e8a50-c697-4abb-8a9f-11c8c0f2dd14
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 21, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 6c685ad4
8ad0c28 
/unhold 6ff99f52-2745-4843-be4c-84a581c87d3b
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 21, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 1a2cbc1f
ea2dbb7 
/unhold 86493f0c-1a88-404d-9969-9dea458d2f29
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 22, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 1799980d
2d77013 
/unhold fe6ee451-9b78-4c5d-91ce-b6e88e503144
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Aug 31, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at fdc048de
a91552a 
/unhold bda20f3f-ef81-461d-806c-87d4cc6a1063
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Sep 1, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at ce938737
282d7dd 
/unhold 629e7c4d-4bce-41e0-a905-d74d4e938f1c
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Sep 1, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 64edb0c7
09d289c 
/unhold ea298d6b-3638-4aa1-91bd-0b73212d54b2
@mleray
PLANET-6917 Refactor Counter block to use hydration
d4e103b 
This is to stop using frontendRendered
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Sep 1, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at d4e103b0
d275c75 
/unhold 0f669fb8-9dbf-4550-bafa-da5f23563229
GP-Dan-Tovbein
GP-Dan-Tovbein approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@GP-Dan-Tovbein GP-Dan-Tovbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Tested locally and worked great! I've left some comments but nothing blocks the merge.

assets/src/blocks/Counter/CounterBlock.js Show resolved Hide resolved
assets/src/blocks/Counter/CounterFrontend.js Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
assets/src/blocks/Counter/CounterBlock.js Show resolved Hide resolved
assets/src/blocks/Counter/CounterBlock.js Show resolved Hide resolved
assets/src/blocks/Counter/CounterBlock.js Outdated Show resolved Hide resolved
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Sep 11, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 0824a2be
a5800de 
/unhold 3ce3435b-28ce-46f3-ac58-d7635a37c684
@mleray
Follow-up after PR review
1c4ed85 
These are small improvements
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Sep 11, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 1c4ed85a
efc4bb0 
/unhold db62d82b-7521-4ce0-bc9d-4e04d8215bab
@mleray
Follow-up after PR review
0069bd8 
Remove props destructuring
planet-4 added a commit to greenpeace/planet4-test-janus that referenced this pull request Sep 11, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1099 at 0069bd86
052e685 
/unhold 6b3b6588-6579-40cf-83ac-886b5f24a88e
@GP-Dan-Tovbein
Copy link
Contributor

Code still looking good ! Excellent work 🏅

@mleray mleray merged commit f087c82 into main Sep 11, 2023
14 checks passed
@mleray mleray deleted the counter-block-refactor branch September 11, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GP-Dan-Tovbein GP-Dan-Tovbein GP-Dan-Tovbein approved these changes

Assignees

@mleray mleray

Labels
Review [Test Env] janus
Projects
None yet
Milestone
No milestone
3 participants
@mleray @planet-4 @GP-Dan-Tovbein