Refactor Covers block to use hydration #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Aug 22, 2023
/unhold f959dcbc-18cd-4568-be02-54d5429a522f
Test instance is ready 🚀🌑 oberon | admin | blocks report | CircleCI | composer-local.json ⌚ 2023.09.25 08:44:46 |
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
e30d408
to
0d638e9
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Aug 22, 2023
/unhold c7ab61f3-ec2f-41ab-84de-50c680d4a0e9
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Aug 24, 2023
/unhold e84b88d4-f856-4d79-852d-a15ba1654898
mleray
force-pushed
the
covers-block-hydration-refactor
branch
2 times, most recently
from
0d89614
to
8929c03
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Aug 25, 2023
/unhold 967f61dd-4214-4da9-8f69-038ce4b2dfcd
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
8929c03
to
45b7f6e
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Aug 31, 2023
/unhold 5075f23f-cc75-4113-981a-8e033ae1e431
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
45b7f6e
to
a30c1f5
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Sep 12, 2023
/unhold 6bfc7518-326d-4b0b-947c-67f7bd2963c3
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
a30c1f5
to
210f1e7
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Sep 12, 2023
/unhold 9418b41e-c3e9-4b3b-a72d-b15fe248fe93
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
210f1e7
to
28bcbde
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Sep 12, 2023
/unhold 12682693-3588-4711-918f-fca527ff7b1a
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
28bcbde
to
864a366
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Sep 15, 2023
/unhold 96185443-fd13-49ef-b7f9-be80c40010d5
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
864a366
to
3abbc83
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Sep 18, 2023
/unhold 5e45354a-5a31-47df-84be-acaeb139d415
This is to stop using the deprecated frontendRendered function
mleray
force-pushed
the
covers-block-hydration-refactor
branch
from
3abbc83
to
68a0e75
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Sep 25, 2023
/unhold 12c71225-f41f-42e2-967b-14be35da230d
|
SonarCloud complains about duplicated code, it's actually not related to these changes, but I think in this case it makes sense to keep it anyway 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-6917
This is to stop using the deprecated
frontendRenderedfunctionTesting
You can make sure that the Covers block still works as expected, either on local or on the oberon test instance