PLANET-4540 Fix facebook share and remove unused code #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inwerpsel
requested review from
a team,
pablocubico and
sagarsdeshmukh
and removed request for
a team
Inwerpsel
force-pushed
the
PLANET-4540
branch
3 times, most recently
from
ad3e466
to
114ce22
Compare
| @@ -243,7 +243,7 @@ function empty_string_to_false_in_link_new_tab_in_columns_blocks( $block ): arra | |||
| // Yes, that's right, WordPress doesn't follow its own rules here so we have a camel among snakes. | |||
| if ( 'planet4-blocks/columns' === $block['blockName'] ?? null ) { | |||
| foreach ( $block['attrs']['columns'] ?? [] as $key => $column ) { | |||
| if ( true !== $column['link_new_tab'] ) { | |||
| if ( isset( $column['link_new_tab'] ) && true !== $column['link_new_tab'] ) { | |||
|
Hi @Inwerpsel - could you please changes the get |
|
PR looks good to me, the changes works as per JIRA ticket req. General finding -
|
* Facebook share now opens in new tab, providing the social_media_message as quoted text * All SocialMediaCards code was initially copied from the Gallery block as a starting point, however this was never cleaned up. This removes some of it, except for the focal points, which don't work but it is not clear whether it should be removed or the functionality should be implemented. * Remove the conversion from shortcode. * Prevent notices for the link_new_tab fix
Inwerpsel
force-pushed
the
PLANET-4540
branch
from
114ce22
to
7d1581c
Compare
Yeah I saw some of those issues as well, but it's so much that it deserves its own ticket. Perhaps we can take those remarks along when we fix the focal point behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
social_media_message as quoted text
block as a starting point, however this was never cleaned up. This
removes some of it, except for the focal points, which don't work but it
is not clear whether it should be removed or the functionality should be
implemented.