Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

PLANET-4348 Bring gutenberg plugin up to date with classic plugin #10

Merged
merged 1 commit into from
Oct 31, 2019
Merged

PLANET-4348 Bring gutenberg plugin up to date with classic plugin #10

merged 1 commit into from
Oct 31, 2019

Conversation

dpivo
Copy link
Contributor

@dpivo dpivo commented Oct 29, 2019

  • Added un-migrated code
  • Made sure styles are loading.

Ref: https://jira.greenpeace.org/browse/PLANET-4348

@dpivo dpivo added the Review label Oct 29, 2019
@dpivo dpivo requested a review from a team October 29, 2019 06:51
@comzeradd
Copy link
Member

We could follow the same structure we have on blocks. So campaign-en-block is a mixin that is used for more than one campaign, so move it inside a styles/campaigns/_mixins.scss and include it from there.

@dpivo dpivo added WIP and removed Review labels Oct 30, 2019
@dpivo dpivo force-pushed the PLANET-4348 branch 2 times, most recently from 8af41df to 2adbbb6 Compare October 30, 2019 07:33
@dpivo dpivo changed the title PLANET-4348 fix en-form climate emergency logo not showing PLANET-4348 Bring gutenberg plugin up to date with classic plugin Oct 30, 2019
@dpivo dpivo added Review and removed WIP labels Oct 30, 2019
@Inwerpsel
Copy link
Contributor

The changes to the tease-thankyou.twig template look good to me.

comzeradd
comzeradd approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@comzeradd comzeradd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Just a small indentation fix and it's good to go 🚀

@dpivo
Copy link
Contributor Author

dpivo commented Oct 31, 2019

Looks good 💯

Just a small indentation fix and it's good to go 🚀

@comzeradd Fixed 👌

@comzeradd comzeradd merged commit 60721aa into master Oct 31, 2019
@comzeradd comzeradd deleted the PLANET-4348 branch October 31, 2019 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@comzeradd comzeradd comzeradd approved these changes

Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
3 participants
@dpivo @comzeradd @Inwerpsel