Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-4374 Improve search results to resolve Accessibility and Vertical Spacing #89

Closed
planet-4 opened this issue Sep 21, 2020 · 3 comments
Closed

PLANET-4374 Improve search results to resolve Accessibility and Vertical Spacing #89

planet-4 opened this issue Sep 21, 2020 · 3 comments
Assignees
@dpivo
Labels
Dev development tickets Easy Feature Frontend tickets that mostly require js/css knowledge Good First Issue
Milestone
Review and improv...

Comments

@planet-4
Copy link

planet-4 commented Sep 21, 2020 •
edited by comzeradd

Apply spacing vertical and horizontal so that the results are readable and balanced.

Attached are the measurements for the adjustments. The font weights and design layouts follow the existing search results css settings. The knock back on the image is #000000 Alpha 25%.

Tasks

  • Adjust spacing on the Search results page based on the mockups

Screenshots

Screenshot

Reporter: wmorrisj
Sections: Search

Potentially affected repositories: planet4-master-theme
@planet-4 planet-4 added A11y Dev development tickets Easy Feature Frontend tickets that mostly require js/css knowledge Good First Issue labels Sep 21, 2020
@dpivo dpivo self-assigned this Oct 15, 2020
@dpivo
Copy link

dpivo commented Oct 22, 2020 •
edited

UAT
Go to https://www-dev.greenpeace.org/test-saturn
Search for something

@magalifatome
Copy link

magalifatome commented Oct 23, 2020 •
edited

@dpivo I checked the paddings and the vertical padding between the image and the grey line is not right for XL, L & M screens (see screenshot attached). The vertical padding should be 24px as per in the mockups.

search results-vertical spacing

@comzeradd
Copy link
Member

Fixed at greenpeace/planet4-master-theme#1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpivo dpivo

Labels
Dev development tickets Easy Feature Frontend tickets that mostly require js/css knowledge Good First Issue
Projects
None yet
Milestone
Review and improve accessibility of s...
Development

No branches or pull requests
4 participants
@comzeradd @dpivo @magalifatome @planet-4