Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-5585: Normalize action search results appearance with other results #1236

Merged
merged 1 commit into from Nov 25, 2020

Conversation

lithrel
Copy link
Member

@lithrel lithrel commented Nov 12, 2020

Ref: https://jira.greenpeace.org/browse/PLANET-5585
Ref: https://jira.greenpeace.org/browse/PLANET-4374

Background images for Take Action pages on search results are pixelated and make the text hard to read

This PR makes the actions in a search result look like the other results.
It also fixes general search results layout.

Fix

  • Suppression of some exception rules and markup specific to action results.
  • Added a margin-top to the button so it's not stuck under the text.
  • Fixed some margins, paddings, width and markup so that it fits the layout given in https://jira.greenpeace.org/browse/PLANET-4374

fix-search-results

Test

@lithrel lithrel added Review UAT Needed This PR requires User Acceptance Tests before merge labels Nov 12, 2020
@lithrel lithrel self-assigned this Nov 12, 2020
@lithrel lithrel changed the title PLANET-5585: Normalize action search results with other results PLANET-5585: Normalize action search results appearance with other results Nov 12, 2020
Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 One thing I noticed on the test instance is that the links just reload the page instead of going to the post, which is strange but it seems unrelated since it also happens in other test instances 🤷‍♀️

@lithrel
Copy link
Member Author

lithrel commented Nov 13, 2020

Ah right, got it locally too, I think it's when Elasticsearch is not ready or hasn't indexed anything yet, we don't handle this very well 😬 I'll open another ticket for that

@lithrel lithrel force-pushed the planet-5585 branch 4 times, most recently from 0a79c45 to f38dfff Compare November 20, 2020 13:58
Ref: https://jira.greenpeace.org/browse/PLANET-5585

> Background images for Take Action pages on search results are pixelated and make the text hard to read

Suppression of some exception rules and markup for action results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review UAT Needed This PR requires User Acceptance Tests before merge
Projects
None yet
2 participants