fix: can not run in Python repl #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuebinsu
approved these changes
Jan 17, 2023
| @@ -268,9 +268,21 @@ def create_in_db(self, db: Database) -> None: | |||
| for param in func_sig.parameters.values() | |||
| ] | |||
| ) | |||
| # make inspect.getsource can run in Python REPL(IPython do not have this issue) | |||
| # CPython issue https://github.com/python/cpython/issues/57129 | |||
There was a problem hiding this comment.
Some thoughts after leaning this magical library:
Suggested change
| # CPython issue https://github.com/python/cpython/issues/57129 | |
| # CPython issue https://github.com/python/cpython/issues/57129 | |
| # TODO: in the future, we might want to use `dill.dumps(func, recurse=True)` | |
| # to send the function to the DBMS with dependencies like imports. |
There was a problem hiding this comment.
that will be wonderful we will use this library more not only the getsource things
greenplumpython/func.py
Outdated
| # CPython issue https://github.com/python/cpython/issues/57129 | ||
| try: | ||
| source: str = inspect.getsource(self._wrapped_func) | ||
| # if run inspect.getsource(func) in REPL will rasie IOError |
There was a problem hiding this comment.
Suggested change
| # if run inspect.getsource(func) in REPL will rasie IOError | |
| # if run inspect.getsource(func) in REPL will raise IOError |
beeender
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr fix can not run greenplumpython in python repl
see issue python/cpython#57129