Skip to content

Commit

Permalink
Remove 9.4 Merge FIXME regarding pm_launch_walreceiver
Browse files Browse the repository at this point in the history
The pm_launch_walreceiver variable is still needed to handle deadlocks
during parallel segment start. Removing the logic will result in
CAC_STARTUP being received and pg_ctl being stuck waiting for PQPING_OK.
The pm_launch_walreceiver variable is used to send Greenplum-specific
CAC_MIRROR_READY so that pg_ctl can continue.

Relative commit:
b824fe8

Co-authored-by: Ekta Khanna <ekhanna@pivotal.io>
Co-authored-by: Jimmy Yih <jyih@pivotal.io>
  • Loading branch information
khannaekta and jimmyyih committed Jan 10, 2019
1 parent 22727ac commit dc5acb7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/backend/postmaster/postmaster.c
Expand Up @@ -155,6 +155,7 @@ void FtsProbeMain(int argc, char *argv[]);
* assumption is am_ftshandler must be set if this is set.
*/
bool am_mirror = false;
/* GPDB specific flag to handle deadlocks during parallel segment start. */
bool pm_launch_walreceiver = false;

/*
Expand Down Expand Up @@ -6167,7 +6168,7 @@ MaybeStartWalReceiver(void)
{
WalReceiverPID = StartWalReceiver();
WalReceiverRequested = false;
/* GPDB_94_MERGE_FIXME: pg94 stable does not have pm_launch_walreceiver. Do we need that? */

/* wal receiver has been launched */
pm_launch_walreceiver = true;
}
Expand Down

0 comments on commit dc5acb7

Please sign in to comment.