Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in PolicyEagerFreeAssignOperatorMemoryKB makes query end without calling mppExecutorCleanup #12690

Closed
violet2016 opened this issue Oct 13, 2021 · 2 comments · Fixed by #12694
Closed

error in PolicyEagerFreeAssignOperatorMemoryKB makes query end without calling mppExecutorCleanup #12690

violet2016 opened this issue Oct 13, 2021 · 2 comments · Fixed by #12694
Assignees
@Aegeaner
Labels
type: bug

Comments

@violet2016
Copy link
Member

Bug Report

In GPDB6, when memory is limit, query could throw an error "insufficient memory reserved for statement" without calling mppExecutorCleanup function and left some hooks should be called in the function not called at all.

Greenplum version or build

6.17.5

OS version and uname -a

centos 7

autoconf options used ( config.status --config )

Installation information ( pg_config )

Expected behavior

mppExecutorCleanup should be called at the end whenever an error happened.

Actual behavior

Step to reproduce the behavior

  1. attach a running gpdb postgres connecton process with gdb, set breakpoints at PolicyEagerFreeAssignOperatorMemoryKB and mppExecutorCleanup
  2. run a query like "select 1" with the postgres connection
  3. when break at PolicyEagerFreeAssignOperatorMemoryKB, step before the condition line of the errmsg
  4. set ctx.groupTree->groupMemKB to 1
  5. the error will occure
  6. You can see gdb not stop at the breakpoint of mppExecutorCleanup
@Aegeaner Aegeaner mentioned this issue Oct 14, 2021
Merged
5 tasks
@Aegeaner Aegeaner self-assigned this Oct 14, 2021
@Aegeaner Aegeaner linked a pull request Oct 20, 2021 that will close this issue
Handling exception to call mppExecutorCleanup in standard_ExecutorStart #12694
Merged
5 tasks
adam8157 pushed a commit that referenced this issue May 25, 2022
@Aegeaner
Handling exception to call mppExecutorCleanup in standard_ExecutorSta…
7e5b7c7 
…rt (#12694)

According to a reported error in PolicyEagerFreeAssignOperatorMemoryKB makes                                                                                                                                                           query end without calling mppExecutorCleanup #12690, the code path in                                                                                                                                                                  `standard_ExecutorStart` didn't handle exception in
`PolicyAutoAssignOperatorMemoryKB` and `PolicyEagerFreeAssignOperatorMemoryKB`
calling, which may cause the OOM exception not to be handled in
`standard_ExecutorStart` but throw to upper `PortalStart` methods, while there
is also an exception handling mechanism in `PortalStart` but `mppExecutorCleanup`
will not call because `portal->queryDesc` will be `NULL` in certain transaction states.

This commit fixes it.
Aegeaner added a commit to Aegeaner/gpdb that referenced this issue May 25, 2022
@Aegeaner
Handling exception to call mppExecutorCleanup in standard_ExecutorSta…
fe0f592 
…rt (greenplum-db#12694)

According to a reported error in PolicyEagerFreeAssignOperatorMemoryKB makes                                                                                                                                                           query end without calling mppExecutorCleanup greenplum-db#12690, the code path in                                                                                                                                                                  `standard_ExecutorStart` didn't handle exception in
`PolicyAutoAssignOperatorMemoryKB` and `PolicyEagerFreeAssignOperatorMemoryKB`
calling, which may cause the OOM exception not to be handled in
`standard_ExecutorStart` but throw to upper `PortalStart` methods, while there
is also an exception handling mechanism in `PortalStart` but `mppExecutorCleanup`
will not call because `portal->queryDesc` will be `NULL` in certain transaction states.

This commit fixes it.
@Aegeaner Aegeaner mentioned this issue May 25, 2022
Merged
5 tasks
adam8157 pushed a commit that referenced this issue Jul 7, 2022
@Aegeaner
Handling exception to call mppExecutorCleanup() in standard_ExecutorS…
feb2856 
…tart()

According to a reported error in `PolicyEagerFreeAssignOperatorMemoryKB()`
makes query end without calling `mppExecutorCleanup()` #12690, the code path
in `standard_ExecutorStart()` didn't handle exception in
`PolicyAutoAssignOperatorMemoryKB()` and `PolicyEagerFreeAssignOperatorMemoryKB()`
calling, which may cause the OOM exception not to be handled in
`standard_ExecutorStart()` but throw to upper `PortalStart()` methods, while there
is also an exception handling mechanism in `PortalStart()` but `mppExecutorCleanup()`
will not call because `portal->queryDesc` will be `NULL` in certain transaction states.
@Aegeaner Aegeaner mentioned this issue Jul 28, 2022
Merged
5 tasks
24nishant pushed a commit to 24nishant/gpdb that referenced this issue Oct 17, 2022
@Aegeaner
Handling exception to call mppExecutorCleanup() in standard_ExecutorS…
54c04a1 
…tart()

According to a reported error in `PolicyEagerFreeAssignOperatorMemoryKB()`
makes query end without calling `mppExecutorCleanup()` greenplum-db#12690, the code path
in `standard_ExecutorStart()` didn't handle exception in
`PolicyAutoAssignOperatorMemoryKB()` and `PolicyEagerFreeAssignOperatorMemoryKB()`
calling, which may cause the OOM exception not to be handled in
`standard_ExecutorStart()` but throw to upper `PortalStart()` methods, while there
is also an exception handling mechanism in `PortalStart()` but `mppExecutorCleanup()`
will not call because `portal->queryDesc` will be `NULL` in certain transaction states.
@adam8157
Copy link
Contributor

adam8157 commented Dec 20, 2022 •
edited

Status summary: the first fix (#12694) has a problem, so we reverted it on the 6X_STABLE, and had the following fix (#13870) on the main branch.

adam8157 added a commit to adam8157/gpdb that referenced this issue Dec 20, 2022
@adam8157
Handling exception to call the hook in standard_ExecutorStart
5851198 
Issue greenplum-db#12690, the code path in `standard_ExecutorStart` didn't handle
exception of `Policy*AssignOperatorMemoryKB`, which may cause the OOM
exception not handled in `standard_ExecutorStart` but throw to upper
`PortalStart` methods, in that case the hook needed by GPCC will not
be called. This commit fixed the issue.
@adam8157 adam8157 mentioned this issue Dec 20, 2022
Merged
@adam8157
Copy link
Contributor

The new 6X version fix: #14677

adam8157 added a commit that referenced this issue Jan 10, 2023
@adam8157
Handling exception to call the hook in standard_ExecutorStart
6f73f4d 
Issue #12690, the code path in `standard_ExecutorStart` didn't handle
exception of `Policy*AssignOperatorMemoryKB`, which may cause the OOM
exception not handled in `standard_ExecutorStart` but throw to upper
`PortalStart` methods, in that case the hook needed by GPCC will not
be called. This commit fixed the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aegeaner Aegeaner

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling exception to call mppExecutorCleanup in standard_ExecutorStart Aegeaner/gpdb
3 participants
@adam8157 @violet2016 @Aegeaner