Store partition key in gp_partition_template #14508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax does not allow ADD PARTITION command to include a subpartition template
l-wang
force-pushed
the
store-partkey-in-template
branch
4 times, most recently
from
047a40c
to
1fc9c47
Compare
Previously, when subpartition template is present, ALTER TABLE ADD PARTITION uses the current first child's partition key to work together with the gpPartitionDefinition stored in the template. This could introduce inconvenience to the users because the first child partition may change over time as a new child partitions can be created and old child partitions can be detached, and the partition keys of different child partitions could differ if users have used the upstream syntax to create new child partitions. This patch stores the partition key along side of the gpPartitionDefinition in the gp_partition_template table, so that the subpartition template is more self-contained.
l-wang
force-pushed
the
store-partkey-in-template
branch
from
1fc9c47
to
b12e30f
Compare
|
@l-wang I believe plan is not to proceed with this change, right? Please can you reflect latest status for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some reminders before you submit the pull request
make installcheck