Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - foreign data wrapper sql and catalog ref page updates #6412

Merged
merged 3 commits into from Dec 7, 2018

Conversation

lisakowen
Copy link
Contributor

in this PR:

  • update FDW-related sql and catalog ref pages to postgresql 9.4
  • add greenplum-specific foreign table option named mpp_execute
  • misc edits (typos, corrections, wording changes)

NOT in this PR:

  • "using" type info, like how to develop a greenplum FDW - this will come in a separate PR

questions:

  • doe CREATE/ALTER FOREIGN TABLE support the TRIGGER and REPLICA TRIGGER clauses?
  • does ALTER FOREIGN TABLE support the "ALTER [ COLUMN ] column_name SET STATISTICS ..." clause?

doc review site links:

@lisakowen lisakowen changed the title docs - foreign data wrapper sql and catalog re page updates docs - foreign data wrapper sql and catalog ref page updates Dec 4, 2018
Copy link
Contributor

@dyozie dyozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@adam8157 adam8157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two code snippets in create_foreign_table.sgml, does our doc need them?

@lisakowen
Copy link
Contributor Author

thank you for reviewing, @adam8157 ! i was thinking that those code snippets are more developer-focused than end-user-focused, and might be better placed in the topic where we discuss how to write a foreign data wrapper. (this topic is not yet written.) do you agree?

@dyozie
Copy link
Contributor

dyozie commented Dec 5, 2018

Although I'd agree that developer-focused info might be better placed elsewhere, we should weigh that against the maintainability of keeping the docs more in sync with the postgresql docs for future merges.

@lisakowen
Copy link
Contributor Author

@dyozie - the code excerpt is not in the postgresql docs. it is a greenplum addition.

@dyozie dyozie merged commit 8a433b4 into greenplum-db:master Dec 7, 2018
@lisakowen lisakowen deleted the docs/fdw-more branch March 15, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants