Fix entries for mirror host in pg_hba.conf #8597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchampio
reviewed
Sep 11, 2019
bhuvnesh2703
force-pushed
the
fix-addmirrors
branch
from
d1ffa11
to
460e46a
Compare
|
Thanks @jchampio for the comments, have addressed almost all of it. Take a look |
bhuvnesh2703
force-pushed
the
fix-addmirrors
branch
2 times, most recently
from
fdc87c1
to
f184353
Compare
Primary nodes should allow connections from its corresponding mirror when pg_rewind tries to connect to it. This commit ensure that when mirrors are added using gpaddmirrors the mirror entries are updated on the primary pg_hba which is subsequently copied to the mirror node. This allows connection between primary and mirror when the roles have switched over. Co-authored-by: David Kimura <dkimura@pivotal.io>
bhuvnesh2703
force-pushed
the
fix-addmirrors
branch
from
f184353
to
7c17cd6
Compare
jchampio
reviewed
Sep 12, 2019
jchampio
reviewed
Sep 12, 2019
|
@jchampio any more changes?, let me know.. thanks for feedback.. |
|
For future reference, make sure you squash WIP commits and fixups before merging. |
|
Unfortunately, yeah i realized that after pushing. When i ported to 6X, i did squash it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary nodes should allow connections from its corresponding mirror
when pg_rewind tries to connect to it. This commit ensure that when
mirrors are added using gpaddmirrors the mirror entries are updated on
the primary pg_hba which is subsequently copied to the mirror node. This
allows connection between primary and mirror when the roles have
switched over.