Bumped Spring Framework version to 5.3.33 #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatb-vmware
approved these changes
Mar 15, 2024
| @@ -29,6 +29,10 @@ plugins { | |||
| id 'io.spring.dependency-management' version '1.0.11.RELEASE' | |||
| } | |||
|
|
|||
| // override Spring Framework version to pick the Spring MVC 5.3.33 with the async race condition fix | |||
| // https://github.com/spring-projects/spring-framework/issues/32342 | |||
| ext['spring-framework.version'] = '5.3.33' | |||
There was a problem hiding this comment.
why do we do this dependency override here asext[] but we do the postgres dependency override in a different format down on line 113. Can we not do this override with the others?
There was a problem hiding this comment.
This is the preferred way to override the versions that SpringBoot bundles via their -bom POM. We should also use this for Postgres and Log4j, we can do that as a separate PR.
yimingli-vmware
approved these changes
Mar 15, 2024
axue-broadcom
approved these changes
Mar 18, 2024
denalex
force-pushed
the
bump-spring-5.3.33-main
branch
from
77db375
to
002f744
Compare
denalex
added a commit
that referenced
this pull request
Mar 20, 2024
denalex
added a commit
that referenced
this pull request
Mar 20, 2024
RomaZe
added a commit
to arenadata/pxf
that referenced
this pull request
Apr 22, 2024
We used the Springboot version 2.4.3 because of the bug with queries which contain LIMIT statement. The bug is described here greenplum-db#947 and comes (as figured out) from spring-mvc. In Springboot version 2.7.18 the bug was resolved. Details are here: greenplum-db#1105 Now, we can bump the version 2.4.3 to 2.7.18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Spring Framework (and the associated spring-mvc modules) to versions 5.3.33 to pick the fix for the async race condition (spring-projects/spring-framework#32342).
The race condition was manifesting itself in PXF with
partial file transfer errorthat GPDB would receive from PXF when executing LIMIT queries or queries issued after LIMIT queries with hight load and concurrency. Tomcat would close the connections without writing a 0-length chunk even if there was no error reported in PXF.