Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property equality fix #344

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

McPo
Copy link

@McPo McPo commented May 24, 2016

Added an equals implementation for Properties object. Ran into an issue which raised the following exception.

throw new DaoException("Property '" + property.name + "' is not part of " + dao);

It was caused by evaluating the equality of two property objects using == instead of .equals(), within WhereCollector.java.

I managed to track the origin of the issue to a poorly written unit test within my own codebase which I believe was mocking an object using powermock, in such a scenario == wasn't sufficient. I corrected the unit test, so its no longer a blocker to myself, however providing an equals implementation seems like a good thing to do anyway.

You may wish to remove the WhereCollector unit test as its somewhat redundant. Also whats the deal with the encryption branch. I assume pull requests are being made against master and master will then be merged into encryption before a release.

Ive also sent the contributor agreement.

Thanks,
Emmet

Original issue: #216

@kewang
Copy link

kewang commented Sep 2, 2018

I have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants