Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline v1.12.1: jump to specific time with surpressEvents set to false, onComplete handler not fired! #53

Closed
benwick opened this issue Jul 1, 2014 · 2 comments

Comments

@benwick
Copy link

benwick commented Jul 1, 2014

It seems there is a big API change (or bug) in version 1.12 ... following case: you have onComplete handlers in tweens, which are added into a timeline. You pause this timeline, jumping to the end of it with supressEvents set to false. In version 1.11 the onComplete handlers were fired, in 1.12 they are not. I have made this little fiddle to demonstrate the case: http://jsfiddle.net/3pTrs/7/

As you can see, the alert in the onComplete handler of the second tween won't be called.

@jackdoyle
Copy link
Member

Good catch - this would only happen to an onComplete call in a tween that's in the final render of a timeline (and only in 1.12.0 or 1.12.1). It'll be patched in the next release. If you'd like to get an early preview, let me know.

@jackdoyle
Copy link
Member

Fixed in the latest release.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants