added load&dump interface

[gtarcoder]

No description provided.

[gtarcoder]

@greg7mdp Hi Gregory, I want to add load and dump interface for set&map instead of using cereal.

I do this because I need to dump and load the map/set very quickly for arithmetic types, e.g. map<uint32_t, uint64_t>, fortunately all necessary data of these types are stored in ctrl_ and slots_ area so we can dump&load ctrl_ and slots_ directly.

Could you help to review that? Any comment would be appreciated.

[greg7mdp]

Hi @gtarcoder,

Thanks for the change. The tests fail line 3298:

/Users/travis/build/greg7mdp/parallel-hashmap/parallel_hashmap/phmap.h:3298:34: error: use of undeclared identifier 'dump_path'
if (!inner.set_.dump(dump_path)) {

[gtarcoder]

Hi @gtarcoder,

Thanks for the change. The tests fail line 3298:

/Users/travis/build/greg7mdp/parallel-hashmap/parallel_hashmap/phmap.h:3298:34: error: use of undeclared identifier 'dump_path'
if (!inner.set_.dump(dump_path)) {

Hi @greg7mdp ， have fixed errors now. And have made more changes to this PR, any comments ?

[greg7mdp]

The IsStringOrArithmeticType check is not right, If you used long strings in your test you would see that the dump does not work because the string has an internal pointer. In any case I think you should use is_trivially_copyable instead because this is exactly what we need for the dump.

Somehow I tried updating your change and I messed up my local github repository... trying to fix it - I have a support ticket with github.

[greg7mdp]

Hi @gtarcoder , I merged your pull request by mistake, and then I undid it. Sorry about that!

[greg7mdp]

@gtarcoder , please submit a new pull request.

[gtarcoder]

@gtarcoder , please submit a new pull request.

Hi @greg7mdp , sorry for troubles, I will create a new PR.