ResourceCollection lookup should also search against resource_name #2411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I hit a problem with
belongs_to :foo_bar
where:foo_bar
refers to a resource alias:As it stands, the resource is never found in the ResourceCollection and you get a lookup error. It appears belongs_to assumes the symbol is an underscored class name. I've patched the find predicate to check the resource_name as well as the resource_class when searching the collection.
What do you reckon? Is this sensible?